Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Page Builder great again #1230

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Make Page Builder great again #1230

merged 2 commits into from
Dec 10, 2024

Conversation

FabienLelaquais
Copy link
Member

Addresses #1207.

@FabienLelaquais FabienLelaquais added 📈 Improvement Improvement of a feature. 📄 Documentation Internal or public documentation 🟧 Priority: High Stalls work on the project or its dependents labels Dec 10, 2024
@FabienLelaquais FabienLelaquais self-assigned this Dec 10, 2024
FlorianJacta
FlorianJacta reviewed Dec 10, 2024
View reviewed changes
docs/refmans/gui/viselements/generic/tree.md_template
```python
import taipy.gui.builder as tgb
...
tgb.tree("value", lov="Item 1;Item 2;Item 3", expanded=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have lists in lov for Python API in this context?

Copy link
Member Author

@FabienLelaquais FabienLelaquais Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

FlorianJacta
FlorianJacta reviewed Dec 10, 2024
View reviewed changes
docs/tutorials/articles/understanding_gui/step_05/step_05.md
=== "Python"
```python
tgb.text("## Positive", mode="md")
tgb.text("{np.mean(dataframe['Score Pos'])}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When lambda functions will work properly, this could be rewritten

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I... think they are.
Will you change that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

FlorianJacta
FlorianJacta approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@FlorianJacta FlorianJacta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but LGTM

AlexandreSajus
AlexandreSajus approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FabienLelaquais FabienLelaquais merged commit eb21622 into develop Dec 10, 2024
1 check passed
@FabienLelaquais FabienLelaquais deleted the doc/#1207-put-page-builder-syntax-first branch December 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianJacta FlorianJacta FlorianJacta approved these changes

@AlexandreSajus AlexandreSajus AlexandreSajus approved these changes

Assignees

@FabienLelaquais FabienLelaquais

Labels
📄 Documentation Internal or public documentation 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabienLelaquais @AlexandreSajus @FlorianJacta